Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update images to ubuntu 22.04 & fix integ test #1532

Merged
merged 2 commits into from
Dec 20, 2024
Merged

update images to ubuntu 22.04 & fix integ test #1532

merged 2 commits into from
Dec 20, 2024

Conversation

xiaoyu-work
Copy link
Contributor

@xiaoyu-work xiaoyu-work commented Dec 20, 2024 •
edited
Loading

Describe your changes

  • Update images to ubuntu 22.04.
    • GPU image may nee to be updated to cuda 12.x.
  • Fix integ test to unblock pipeline.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@xiaoyu-work xiaoyu-work merged commit 0e328a5 into main Dec 20, 2024
25 checks passed
@xiaoyu-work xiaoyu-work deleted the xiaoyu/test branch December 20, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jambayk jambayk jambayk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyu-work @jambayk