-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds the ability to define error responses on error codes instead of default #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested review from
darrelmiller,
irvinesunday and
xuzhg
as code owners
January 27, 2022 20:29
xuzhg
reviewed
Jan 27, 2022
xuzhg
reviewed
Jan 27, 2022
src/Microsoft.OpenApi.OData.Reader/Common/OpenApiOperationExtensions.cs
Outdated
Show resolved
Hide resolved
@xuzhg thanks for reviewing. |
This was referenced Jan 28, 2022
…t responses Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…nsions.cs Co-authored-by: Sam Xu <saxu@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
force-pushed
the
feature/error-schema
branch
from
February 1, 2022 16:27
3f0ac21
to
b1dba80
Compare
proposal design was approved and implemented, waiting for final review before merge. |
Looks good to me, of course, if you can make the code alignment for better readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #165
This PR adds a new setting
ErrorResponsesAsDefault
defaulttrue
to avoid breaking existing users.When true, the error responses will only be described as the following
When false they'll be described as the following
This change is made so client generators can "better understand" what the error payloads look like and generate more accurate SDKs.