Updated the marker text that is used to figure out if SQL Server container is up and ready #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichalla
commented
May 6, 2019
| @@ -53,7 +53,7 @@ protected override bool WaitUntilDbServerIsUp() | |||
| { | |||
| try | |||
| { | |||
| var lookUpText = "SQL Server is now ready for client connections"; | |||
| var lookUpText = "The default language (LCID 0) has been set for engine and full-text services."; | |||
There was a problem hiding this comment.
This is the final message that is printed when the SQL Server is up and ready. Even though the earlier message says 'ready for client connections' I have received errors some times when setting up data.
Also regarding setting up data, one thing we could do is to bake the data into the image itself. This improves the perf a bit, but still does not avoid the problem of making requests to the container before it is ready.
kichalla
force-pushed
the
kichalla/fix.sql.server.test
branch
from
443ddfc
to
420e990
Compare
gpcastro
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.