.NET Core startup script: Run app executable if present, else fallback to app's dll #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to app's dll This is to support the following scenarios: 1. End users can do a zip deploy of a self-contained app into AppService and our runtime container should use the executable, so instead of doing 'dotnet myappname.dll', we should run './myappname'. This is because the whole point of self-contained app is to use the packaged runtime which is present in the output. 2. Starting 3.0 .NET Core, a regular 'dotnet publish' creates both the executable and dll.
kichalla
commented
May 15, 2019
| scriptBuilder.WriteString(" startUpCommand=\"$userStartUpCommand\"\n") | ||
| scriptBuilder.WriteString(" if [ -f \"$userStartUpCommand\" ]; then\n") | ||
| scriptBuilder.WriteString(" chmod 755 \"$userStartUpCommand\"\n") | ||
| scriptBuilder.WriteString(" len=${#userStartUpCommand[@]}\n") |
There was a problem hiding this comment.
This new block keeps the logic that AppService currently uses
| @@ -7,7 +7,7 @@ | |||
| using Microsoft.Extensions.Hosting; | |||
| using Microsoft.Extensions.Logging; | |||
|
|
|||
| namespace NetCoreApp30WebApp | |||
| namespace NetCoreApp30.WebApp | |||
There was a problem hiding this comment.
Just to verify if having a . in the name breaks the tests
gpcastro
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the following scenarios:
so instead of doing 'dotnet myappname.dll', we should run './myappname'. This is because the whole point of self-contained app
is to use the packaged runtime which is present in the output.