Add --no-cache for building base images #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichalla
reviewed
May 15, 2019
build/build-runtimeimages-bases.sh
Outdated
| @@ -85,7 +85,7 @@ for dockerFile in $dockerFiles; do | |||
| cd $REPO_DIR | |||
|
|
|||
| echo | |||
| docker build -f $dockerFile -t $localImageTagName $labels . | |||
| docker build --no-cache -f $dockerFile -t $localImageTagName $labels . | |||
There was a problem hiding this comment.
As we discussed in our meeting, should we have this behind a flag so that we do it only when required?
There was a problem hiding this comment.
I will like that to be adhoc
There was a problem hiding this comment.
I've changed the approach now, so only the steps we want to always run won't be cached.
arroyc
approved these changes
May 15, 2019
kichalla
approved these changes
May 15, 2019
| @@ -33,6 +33,10 @@ RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux- | |||
| && tar -xJf "node-v$NODE_VERSION-linux-x64.tar.xz" -C /usr/local --strip-components=1 \ | |||
| && rm "node-v$NODE_VERSION-linux-x64.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt | |||
|
|
|||
| # This is a way to avoid using caches for the next stages, since we want the remaining steps | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing issues since we were not reinstalling the latest version of tools that go in the image.