Python runtime images share same structure as build image #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gpcastro
commented
May 17, 2019
gpcastro
commented
- Unify our python images so the binaries are located in the same place both at build and runtime
- Migrate Python base images to stretch, also for consistency
kichalla
approved these changes
May 17, 2019
arroyc
reviewed
May 21, 2019
| @@ -228,8 +228,8 @@ RUN apt-get update \ | |||
| # https://github.com/docker-library/python/issues/147 | |||
| ENV PYTHONIOENCODING UTF-8 | |||
| COPY build/__python-versions.sh /tmp | |||
| COPY --from=mcr.microsoft.com/oryx/python-build-2.7:20190322.1 /opt /opt | |||
| COPY --from=mcr.microsoft.com/oryx/python-build-3.6:20190322.1 /opt /opt | |||
| COPY --from=mcr.microsoft.com/oryx/python-build-2.7:20190402.1 /opt /opt | |||
There was a problem hiding this comment.
note: we need to change this again soon something like mcr.microsoft.com/oryx/python-build:2.7-20190402.1
arroyc
reviewed
May 21, 2019
| ENV PYTHON_VERSION %PYTHON_FULL_VERSION% | ||
|
|
||
| # Add python binaries from Oryx base image | ||
| COPY --from=mcr.microsoft.com/oryx/python-build-%PYTHON_VERSION%:%IMAGE_TAG% /opt /opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.