Tests: Added tests for .NET Core 1.0 and 2.0 apps #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichalla
commented
May 23, 2019
| var appOutputDir = $"{appDir}/myoutputdir"; | ||
| var buildImageScript = new ShellScriptBuilder() | ||
| // NOTE: we are using 1.1 'sdk' version to build 1.0 netcoreapp | ||
| .AddCommand($"oryx build {appDir} -l dotnet --language-version 1.1 -o {appOutputDir}") |
There was a problem hiding this comment.
Here we have a 1.0 runtime app built with 1.1 SDK
| "-c", | ||
| buildImageScript | ||
| }, | ||
| "oryxdevms/dotnetcore-1.0", |
There was a problem hiding this comment.
The runtime image is still 1.0
| var appOutputDir = $"{appDir}/myoutputdir"; | ||
| var buildImageScript = new ShellScriptBuilder() | ||
| // NOTE: we are using 2.1 'sdk' version to build 2.0 netcoreapp | ||
| .AddCommand($"oryx build {appDir} -l dotnet --language-version 2.1 -o {appOutputDir}") |
There was a problem hiding this comment.
Similarly this is a 2.0 runtime app built with 2.1 SDK
| "-c", | ||
| buildImageScript | ||
| }, | ||
| "oryxdevms/dotnetcore-2.0", |
There was a problem hiding this comment.
The runtime image is still 2.0
| using System.Threading.Tasks; | ||
| using Microsoft.AspNetCore.Mvc; | ||
|
|
||
| namespace app.Controllers |
There was a problem hiding this comment.
This apps were taken from the share that @JennyLawrance shared with us
gpcastro
approved these changes
May 23, 2019
|
Should we have a |
Good question. These apps were from Jenny, so we do not know their source. From their structure it looks like they are dotnet core cli template-based projects, so we are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.