Update nodejs build doc #1820
Merged
Update nodejs build doc #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daniv-msft
commented
Jan 14, 2023
daniv-msft
commented
- The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
- Tests are included and/or updated for code changes.
- Proper license headers are included in each file.
pauld-msft
reviewed
Jan 17, 2023
doc/runtimes/nodejs.md
Outdated
| 4. Run `npm install` without any flags, which includes npm `preinstall` and | ||
| `postinstall` scripts and also installs devDependencies. | ||
| 4. Run `npm install`, which includes npm `preinstall` and `postinstall` scripts and also installs devDependencies. | ||
| The `--unsafe-perm` flag is added to the NPM install command, as well as the `--production` flag if some production |
There was a problem hiding this comment.
I actually removed the unsafe-perm flag in this PR, as it isn't needed now that the permissions are updated: #1759 (review)
There was a problem hiding this comment.
Ah good call, thanks. I'll update this.
There was a problem hiding this comment.
Can't believe I forgot this one. Here is the update.
william-msft
previously approved these changes
Jan 17, 2023
william-msft
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.