Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wali/nuget package vulnerability fix #2068

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Wali/nuget package vulnerability fix #2068

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4a7150
system.private.uri vulnerability testing
waliMSFT Jul 14, 2023
c7e329a
update the version of System.Private.Uri to 4.3.2
waliMSFT Jul 17, 2023
7a14a52
only keeping the System.Private.Uri dependency in the Common project
waliMSFT Jul 18, 2023
a70370d
addressed PR comment
waliMSFT Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/BuildServer/BuildServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.17.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="RunProcessAsTask" Version="1.2.4" />
<PackageReference Include="runtime.unix.System.Private.Uri" Version="4.3.2" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind providing some context as to why this runtime.unix.System.Private.Uri package was also added as a package reference throughout these .csproj files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a screenshot or a description of the vulnerability we are solving would be nice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look on the comment: #2068 (comment)

<PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />
<PackageReference Include="System.Private.Uri" Version="4.3.2" />
</ItemGroup>

</Project>
2 changes: 2 additions & 0 deletions src/Detector/Detector.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
<PackageReference Include="Microsoft.Extensions.Http" Version="7.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="runtime.unix.System.Private.Uri" Version="4.3.2" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure if we need to include these package references in Detector.csproj and Detector.Test.csproj since they already reference the Common.csproj project, so these package references should be propagated downstream to these projects, but it's worth double-checking this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look on the comment: #2068 (comment)

<PackageReference Include="SemanticVersioning" Version="2.0.2" />
<PackageReference Include="System.Private.Uri" Version="4.3.2" />
<PackageReference Include="xunit" Version="2.4.2" />
</ItemGroup>

Expand Down
2 changes: 2 additions & 0 deletions src/Oryx.Common/Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging" Version="7.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="runtime.unix.System.Private.Uri" Version="4.3.2" />
<PackageReference Include="System.Private.Uri" Version="4.3.2" />
daniv-msft marked this conversation as resolved.
Show resolved Hide resolved
<PackageReference Include="Tomlyn" Version="0.16.2" />
<PackageReference Include="YamlDotNet" Version="12.3.1" />
</ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions tests/Detector.Tests/Detector.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
<PackageReference Include="runtime.unix.System.Private.Uri" Version="4.3.2" />
<PackageReference Include="System.Private.Uri" Version="4.3.2" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PrivateAssets>all</PrivateAssets>
Expand Down