SDL requirement- package version update #2088
Conversation
| @@ -22,4 +22,11 @@ | |||
| <Folder Include="Commons\" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Update="SmartAnalyzers.CSharpExtensions.Annotations" Version="4.2.8"> | |||
There was a problem hiding this comment.
It looks like we can just update the Directory.Build.props file that contains a reference to this package and will automatically be imported in all projects.
There was a problem hiding this comment.
you are right. thanks for the suggestion
| <EmbeddedResource Include="Golang\GolangBashBuildSnippet.sh.tpl" WithCulture="false" /> | ||
| <EmbeddedResource Include="Python\JupyterNotebookBashBuildSnippet.sh.tpl" WithCulture="false" /> | ||
| <EmbeddedResource Include="Python\PythonBashBuildSnippet.sh.tpl" WithCulture="false" /> | ||
| <EmbeddedResource Include="Ruby\RubyBashBuildSnippet.sh.tpl" WithCulture="false" /> |
There was a problem hiding this comment.
nit: please remove extra space if not required.
| @@ -18,7 +18,7 @@ | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" /> | |||
| <PackageReference Include="xunit" Version="2.4.2" /> | |||
| <PackageReference Include="Xunit.SkippableFact" Version="1.4.13" /> | |||
| <PackageReference Include="XunitXml.TestLogger" Version="3.0.70" /> | |||
| <PackageReference Include="XunitXml.TestLogger" Version="3.1.11" /> | |||
There was a problem hiding this comment.
Should we also update XunitXml.TestLogger in the other places too?
There was a problem hiding this comment.
Hi @waliMSFT I noticed you updated another the version for another XunitXml.TestLogger in your recent commit. But I see total of 5 files being changed. The screenshot above shows there are 7. Do we not need to update the other 2?
There was a problem hiding this comment.
I forgot to reply on your comment.
I probably missed the other files. I have updated the package on all the files now.
…date_open_source_components_SDL
-- SDL requirement: Open Source Components must be kept up to date and cannot be 18 months old
work item: https://devdiv.visualstudio.com/DevDiv/_boards/board/t/Oryx/Stories/?workitem=1860719