Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version check when setting the condition to install wasm-tools #2255

Closed
wants to merge 2 commits into from
Closed

Remove version check when setting the condition to install wasm-tools #2255

wants to merge 2 commits into from

Conversation

daniv-msft
Copy link
Contributor

@daniv-msft daniv-msft commented Nov 13, 2023 •
edited
Loading

We initially needed to install wasm-tools for .NET versions >=6. Now that 3.1 is EOL, we can just remove the version check.

  • The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
  • Proper license headers are included in each file.

@daniv-msft daniv-msft requested a review from a team as a code owner November 13, 2023 23:56
cormacpayne
cormacpayne approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cormacpayne cormacpayne mentioned this pull request Nov 27, 2023
Merged
2 tasks
@cormacpayne
Copy link
Contributor

Closing in favor of PR #2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

@william-msft william-msft william-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniv-msft @cormacpayne @william-msft