Add jar/zip support #2280
Merged
Add jar/zip support #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
showpune
commented
Dec 15, 2023
showpune
commented
- The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
- Tests are included and/or updated for code changes.
- Proper license headers are included in each file.
cormacpayne
previously approved these changes
Dec 15, 2023
pauld-msft
previously approved these changes
Dec 15, 2023
showpune
dismissed stale reviews from pauld-msft and cormacpayne
via
047e331
yilims
reviewed
Dec 19, 2023
builders/container-apps-internal-registry-demo/startup-script.sh
Outdated
Show resolved
Hide resolved
yilims
suggested changes
Dec 19, 2023
pauld-msft
reviewed
Dec 19, 2023
| mkdir -p $CNB_APP_DIR | ||
| cd $CNB_APP_DIR | ||
| tar -xzf "$temp_app_source_path" | ||
|
|
||
| if [[ $content_type =~ "application/zip" || $content_type =~ "java-archive" ]]; then |
There was a problem hiding this comment.
content type mistmatch between here and application/java-archive above
pauld-msft
previously approved these changes
Dec 19, 2023
yilims
approved these changes
Dec 20, 2023
pauld-msft
reviewed
Dec 20, 2023
builders/container-apps-internal-registry-demo/startup-script.sh
Outdated
Show resolved
Hide resolved
pauld-msft
previously approved these changes
Dec 20, 2023
pauld-msft
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.