Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benv to ignore named versions (#320) #322

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Fix benv to ignore named versions (#320) #322

merged 3 commits into from
Aug 20, 2019

Conversation

kichalla
Copy link
Contributor

No description provided.

@kichalla kichalla requested a review from a team as a code owner August 20, 2019 16:29
arroyc
arroyc reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@arroyc arroyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the PR, :) can you please add some tests … there are some complicated string parsing logic which is difficult to follow

@kichalla
Copy link
Contributor Author

I saw the PR, :) can you please add some tests … there are some complicated string parsing logic which is difficult to follow

@arroyc I added a few tests to this PR now. Please note that we already had other tests cases related to benv in the same test class.

arroyc
arroyc approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@arroyc arroyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests, it's not mandatory, but I think we should also include a failed test (that we discussed) which gets failed with current benv implementation, so that we don't re-investigate in future the cause

@kichalla
Copy link
Contributor Author

but I think we should also include a failed test (that we discussed) which gets failed with current benv implementation, so that we don't re-investigate in future the cause

Yup, added it in latest commit. Thanks.

@kichalla kichalla merged commit 3a147d9 into master Aug 20, 2019
@kichalla kichalla deleted the kichalla/benv.changes branch August 20, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arroyc arroyc arroyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kichalla @arroyc