Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving an issue in php run images by allowing casing in php file extension #352

Merged
merged 10 commits into from
Sep 17, 2019
Merged

Resolving an issue in php run images by allowing casing in php file extension #352

merged 10 commits into from
Sep 17, 2019

Conversation

arroyc
Copy link
Contributor

@arroyc arroyc commented Sep 16, 2019

this pr is to solve the following problem that customer reported

All of our PHP images are no longer able to handle the “PHP” extension if it’s not all in lower case (i.e. index.php). If the name is in any other format such as camel or uppercase (i.e. index.pHp, index.PHP, index.pHP), we’re exposing the whole file

@arroyc arroyc changed the title Resolving major security issue in php run images by allowing casing in php file extension Resolving an issue in php run images by allowing casing in php file extension Sep 16, 2019
@arroyc arroyc marked this pull request as ready for review September 16, 2019 21:58
@arroyc arroyc requested a review from a team as a code owner September 16, 2019 21:58
@arroyc arroyc merged commit 0c6b30c into master Sep 17, 2019
@arroyc arroyc deleted the arroyc/add-apache-conf branch September 17, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kichalla kichalla kichalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arroyc @kichalla