Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typeshed integration #3437

Closed
3 tasks done
zooba opened this issue Dec 5, 2017 · 2 comments
Closed
3 tasks done

Typeshed integration #3437

zooba opened this issue Dec 5, 2017 · 2 comments
Assignees
@zooba
Milestone
15.8

Comments

@zooba
Copy link
Member

zooba commented Dec 5, 2017 •
edited
Loading

Recognize the existence of the typeshed package of type stub files and use it to supplement existing IntelliSense information.

This interacts closely with #82, which provides support for generic type stub files. However, this particular task is complete when we detect and handle sub-paths for the specific case of typeshed.

  • detect installed typeshed module
  • load typeshed module in place of regular analysis
  • merge typeshed info with regular analysis
@zooba zooba added this to the 15.6 milestone Dec 5, 2017
@zooba zooba self-assigned this Dec 7, 2017
@zooba
Copy link
Member Author

zooba commented Dec 7, 2017

Currently we can detect and load typeshed modules, but because we do not merge values it makes IntelliSense worse. Until we merge, the checked in code will not prefer typeshed over normal analysis.

@huguesv huguesv modified the milestones: 15.6, 15.7 Jan 31, 2018
@huguesv huguesv modified the milestones: 15.7, 15.8 Apr 9, 2018
@zooba
Copy link
Member Author

zooba commented May 23, 2018

This issue is not going to address PEP 561 (typing packages), but we should do that once the PEP is accepted.

zooba added a commit to zooba/PTVS that referenced this issue May 25, 2018
@zooba
[WIP] Fixes microsoft#3437 Typeshed integration
af5ca63 
Enables value merging from typeshed
Improves some handling of type annotations in AST imported files
@zooba zooba mentioned this issue May 25, 2018
Merged
zooba added a commit that referenced this issue Jun 5, 2018
@zooba
Merge pull request #4264 from zooba/issue-3437
814dd9b 
Fixes #3437 Typeshed integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
15.8
Development

No branches or pull requests
2 participants
@zooba @huguesv