Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the behavior of Get-GitHubRepository #179

Merged
merged 1 commit into from
May 25, 2020

Conversation

HowardWolosky
Copy link
Member

There were a few problems with this function:

  • -GetAllPublicRepositories didn't actually work. That's now been fixed,
    and support for the optional Since paramater has been added as well.
  • Fixed the ParameterSet handling for all of the parameters to make sure
    that users can only specify parameters relevant with the appropriate
    parameter set given that there are five different use cases for this
    method:
    • Getting repos for the current authenticated user
    • Getting repos for any GitHub user
    • Getting repos for an organization
    • Getting all public repos)
    • Getting a specific GitHub repo

Resolves #178
Helps with #139

There were a few problems with this function:
* -GetAllPublicRepositories didn't actually work.  That's now been fixed,
  and support for the optional Since paramater has been added as well.
* Fixed the ParameterSet handling for all of the parameters to make sure
  that users can only specify parameters relevant with the appropriate
  parameter set given that there are five different use cases for this
  method:
     * Getting repos for the current authenticated user
     * Getting repos for any GitHub user
     * Getting repos for an organization
     * Getting all public repos)
     * Getting a specific GitHub repo

Resolves microsoft#178
@HowardWolosky HowardWolosky added bug This relates to a bug in the existing module. technical debt Work that was postponed by a previous change. labels May 25, 2020
@HowardWolosky HowardWolosky merged commit c4c1ec3 into microsoft:master May 25, 2020
@HowardWolosky HowardWolosky deleted the getRepoParams branch May 25, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This relates to a bug in the existing module. technical debt Work that was postponed by a previous change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-GitHubRepository doesnt show private repository.
1 participant