Removing dependency on PsDesiredStateConfiguration Resource and xPsDesiredStateConfiguration

[erjenkin]

Pull Request (PR) description:
Removing dependency on PsDesiredStateConfiguration Resource which in some cases is out of date and no longer supported.

This Pull Request (PR) fixes the following issues:

This fixes #345 , #363

Task list:

• Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
• Added/updated documentation, comment-based help and descriptions where appropriate?
• Examples appropriately updated?
• New/changed code adheres to Style Guidelines?
• Unit and (optional) Integration tests created/updated where possible?

---

This change is 

[davbowman]

Reviewed 85 of 85 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @erjenkin)

---

StigData/Archive/Windows.Client/U_Windows_10_STIG_V1R14_Manual-xccdf.log, line 3 at r1 (raw file):

V-63423::"Minimum password length,"::"Minimum password length"
V-63429::"Store password using reversible encryption"::"Store passwords using reversible encryption"
V-68819::Registry Path: \SOFTWARE\ Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\::Registry Path: \SOFTWARE\Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\

Looks like a space before Policies?

---

StigData/Archive/Windows.Client/U_Windows_10_STIG_V1R14_Manual-xccdf.log, line 4 at r1 (raw file):

V-63429::"Store password using reversible encryption"::"Store passwords using reversible encryption"
V-68819::Registry Path: \SOFTWARE\ Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\::Registry Path: \SOFTWARE\Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\
V-74413::Registry Path: \SOFTWARE\Policies\Microsoft\ Cryptography\Configuration\SSL\00010002\::Registry Path: \SOFTWARE\Policies\Microsoft\Cryptography\Configuration\SSL\00010002\

Looks like a space before Cryptography?

---

StigData/Archive/Windows.Client/U_Windows_10_STIG_V1R14_Manual-xccdf.log, line 5 at r1 (raw file):

V-68819::Registry Path: \SOFTWARE\ Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\::Registry Path: \SOFTWARE\Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\
V-74413::Registry Path: \SOFTWARE\Policies\Microsoft\ Cryptography\Configuration\SSL\00010002\::Registry Path: \SOFTWARE\Policies\Microsoft\Cryptography\Configuration\SSL\00010002\
V-74415::Registry Path: \SOFTWARE\Policies\Microsoft\MicrosoftEdge\ Privacy\::Registry Path: \SOFTWARE\Policies\Microsoft\MicrosoftEdge\Privacy\

Looks like a space before Privacy?

---

StigData/Archive/Windows.Server.2012R2/U_Windows_2012_and_2012_R2_MS_STIG_V2R12_Manual-xccdf.log, line 4 at r1 (raw file):

V-3472::Registry Path: \Software\Policies\Microsoft\W32time\Parameters\::Remove
V-3472::Value Name:::Remove
V-3472::Registry Hive: HKEY_LOCAL_MACHINE::Remmove

2 M's in Remove

---

StigData/Archive/Windows.Server.2012R2/U_Windows_2012_and_2012_R2_MS_STIG_V2R13_Manual-xccdf.log, line 5 at r1 (raw file):

V-21954::The values are determined by the selection of encryption suites in the policy Computer Configuration >> Windows Settings >> Security Settings >> Local Policies >> Security Options >> "Network Security: Configure encryption types allowed for Kerberos".::Removed
V-21954::For example, when all suites, including the DES suites are selected, the value will be "0x7fffffff (2147483647)".::Value: 0x7ffffff8 (2147483640)
V-80475::Registry Path: \SOFTWARE\ Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\::Registry Path: \SOFTWARE\Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\

Space before Policies on V-80475

---

StigData/Archive/Windows.Server.2012R2/U_Windows_2012_and_2012_R2_MS_STIG_V2R14_Manual-xccdf.log, line 3 at r1 (raw file):

V-2372::"Store password using reversible encryption"::"Store passwords using reversible encryption"
V-6836::"Minimum password length,"::"Minimum password length"
V-80475::Registry Path: \SOFTWARE\ Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\::Registry Path: \SOFTWARE\Policies\Microsoft\Windows\PowerShell\ScriptBlockLogging\

Space before Policies?

[erjenkin]

Reviewable status: 84 of 85 files reviewed, 1 unresolved discussion (waiting on @davbowman)

---

StigData/Archive/Windows.Server.2012R2/U_Windows_2012_and_2012_R2_MS_STIG_V2R12_Manual-xccdf.log, line 4 at r1 (raw file):

Previously, davbowman (David Bowman) wrote…

2 M's in Remove

Done.

[codecov-io]

Codecov Report

Merging #366 into 3.1.0 will increase coverage by 5.69%.
The diff coverage is 70.45%.

@@            Coverage Diff             @@
##            3.1.0     #366      +/-   ##
==========================================
+ Coverage   72.39%   78.08%   +5.69%     
==========================================
  Files          16       16              
  Lines         192      178      -14     
  Branches        3        3              
==========================================
  Hits          139      139              
+ Misses         50       36      -14     
  Partials        3        3

Impacted Files	Coverage Δ
DSCResources/OracleJRE/OracleJRE.schema.psm1	66.66% <50%> (ø)	⬆️
DSCResources/FireFox/FireFox.schema.psm1	66.66% <50%> (ø)	⬆️
DSCResources/SqlServer/SqlServer.schema.psm1	62.5% <50%> (ø)	⬆️
...ources/DotNetFramework/DotNetFramework.schema.psm1	80% <66.66%> (+13.33%)	⬆️
DSCResources/Office/Office.schema.psm1	71.42% <66.66%> (+8.92%)	⬆️
...ources/WindowsFirewall/WindowsFirewall.schema.psm1	80% <66.66%> (+13.33%)	⬆️
DSCResources/IisSite/IisSite.schema.psm1	81.81% <66.66%> (+6.81%)	⬆️
...rces/InternetExplorer/InternetExplorer.schema.psm1	71.42% <66.66%> (+8.92%)	⬆️
...ources/WindowsDefender/WindowsDefender.schema.psm1	80% <66.66%> (+13.33%)	⬆️
DSCResources/IisServer/IisServer.schema.psm1	75% <75%> (+10.71%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd9ac8...609d27d. Read the comment docs.

[davbowman]

Reviewed 1 of 85 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved