Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing nowarn's #16590

Merged
merged 1 commit into from
Mar 1, 2022
Merged

removing nowarn's #16590

merged 1 commit into from
Mar 1, 2022

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Feb 25, 2022

Summary of the Pull Request

What is this about:
removing nu1701 nowarns

What is included in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #Remove all .NET Fx dependencies #8557
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Feb 28, 2022
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What's the point of removing the warning, though?

@crutkas crutkas merged commit 29a2545 into main Mar 1, 2022
@crutkas crutkas deleted the dev/crutkas/removeNU1701flag branch March 1, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants