[Installer]Add version to the winappsdk filename #18543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Add the version to WindowsAppRuntimeInstall.exe so that it doesn't collide with other installers the user might've downloaded for windappsdk, since all the installers are named WindowsAppRuntimeInstall.exe regardless of version.
The Wix bootstrapper will prefer to use a local installer if one is found and it will have the wrong hash if it's not the same version.
What is included in the PR:
Add the version to WindowsAppRuntimeInstall.exe file name.
How does someone test / validate:
Download a different version installer for windowsappsdk to the same path as the PowerToys installer and verify PowerToys is still able to install windowsappsdk without receiving a wrong hash error.
Quality Checklist