Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Color Picker] Don't wait for ColorPicker.exe to close #5866

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

ivan100sic
Copy link
Contributor

Summary of the Pull Request

Unlike PowerLauncher, we can safely immediately terminate ColorPicker.exe when the module is disabled/PT quits.

PR Checklist

  • Applies to ColorPicker and PT Run take 10 seconds to exit #5860
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Ran PT, enabled/disabled Color Picker, terminated PT and checked that CP quits, also all of this when running as admin.

@ivan100sic ivan100sic merged commit 83de168 into microsoft:master Aug 11, 2020
@ivan100sic ivan100sic deleted the color-picker-close-bug branch August 12, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants