Restart the Launcher if it had crashed when invoked

[ivan100sic]

Summary of the Pull Request

Could apply to issues such as this one #6605. If the Launcher crashes, when we invoke it, nothing happens until it is manually restarted. This PR restarts the launcher if we detect that it crashed or exited somehow.

PR Checklist

• Applies to PowerToys Run doesn't open #6605
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Start PT, enable the Launcher, terminate it using the Task Manager and hit the invoke hotkey. The launcher should appear immediately in the Task Manager and should show up on the screen in a few seconds.

[arjunbalgovind]

Could this cause a crash loop if there is some unhandled exception on launcher startup?

[ivan100sic]

Could this cause a crash loop if there is some unhandled exception on launcher startup?

Only if you hit the invoke hotkey, it's no worse than what we have now.

[crutkas]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[htcfreek]

Could this cause a crash loop if there is some unhandled exception on launcher startup?

Only if you hit the invoke hotkey, it's no worse than what we have now.

I know that's maybe not a nice workaround.

But what about adding a counter like trying three time to restart and then stop until hotkey is pressed again.

[enricogior]

@htcfreek

But what about adding a counter like trying three time to restart and then stop until hotkey is pressed again.

No need for doing that, we should spend time making the actual module robust rather than add workarounds.

[alekhyareddy28]

LGTM! Thanks for this. Validated that PT Run is restarted on pressing the hotkey, after it's killed.

[ivan100sic]

@alekhyareddy28
A bit off-topic, I tried to figure out why we need to kill the Launcher instead of quitting it. I tried calling System.Windows.Forms.Application.Exit(); from within the Launcher but that doesn't seem to work. Is this a known issue?

[alekhyareddy28]

@ivan100sic, I'm not aware of it. I remember @somil55 working on the issue where PT Run was not exiting as expected a while back but that was related to objects not being disposed off properly. I think he can add more to this and answer your question.

[dsrivastavv]

@ivan100sic #5860 captures this issue and is discussed in #5860 (comment)