Add wildcard filtering support when dump on exceptions #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inline WCHAR *getWCHARs(const String &src) | ||
| { | ||
| size_t len = src.Length(); | ||
| WCHAR* tempbuff = new WCHAR[len+1]; |
There was a problem hiding this comment.
Check allocation result
There was a problem hiding this comment.
Thanks Mario! I will modify the other two and commit, but I have question for this allocation checking with the below two thoughts:
- There is no checking for other new allocations in the same file.
- The post below says seems we only need to check new allocation with no-throw
https://stackoverflow.com/questions/5197732/should-one-always-check-if-the-new-operator-worked
profiler/src/ProcDumpProfiler.cpp
Outdated
| // WildcardSearch - Search string supports '*' anywhere and any number of times | ||
| // | ||
| //-------------------------------------------------------------------- | ||
| bool WildcardSearch(WCHAR* szClassName, WCHAR* szSearch) |
There was a problem hiding this comment.
Make this part of the profiler class
src/ProfilerHelpers.c
Outdated
| @@ -297,9 +297,10 @@ char* GetEncodedExceptionFilter(char* exceptionFilterCmdLine, unsigned int numDu | |||
| char* exceptionFilter = NULL; | |||
| char* exceptionFilterCur = NULL; | |||
| char tmp[10]; | |||
| size_t len; | |||
MarioHewardt
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wildcard filtering support when dump on exceptions #153