Add support to filter on exception message #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add the new function CorProfiler::GetExceptionMessage 2. Add filter on exception message in CorProfiler::ExceptionThrown 3. Make a core dump file name contains exception name and dump count 4. Modify PrintUsage, man page and README.md to reflect the filter change Signed-off-by: oldzhu <wp_xdzhu@hotmail.com>
… the dump count, modify the testing scripts which try to locate the exception dumps by name accordingly. Signed-off-by: oldzhu <wp_xdzhu@hotmail.com>
…ocdump in the related scripts 2. Add -log option in all procdump command running in the testing scripts for troubleshooting failed testing cases 3. Add sleep betwen the procdump and wget to trigger exception so that procdump is ready for exception before exception thrown 4. Add access call loop checking in profiler to make sure procdump listening on the socket before profiler try to connect Signed-off-by: oldzhu <wp_xdzhu@hotmail.com>
MarioHewardt
reviewed
Feb 6, 2023
tests/integration/scenarios/dotnet_1FilterExceptionMsgDump1Thrown_dump.sh
Outdated
Show resolved
Hide resolved
…f a procdump socket is created or not 2. fix medta leak in CorProfiler::GetExceptionMessage while loop 4. change delete to delete [] in CorProfiler::GetExceptionMessage 3. limit socket access testing to 5 times to avoid endless loop Signed-off-by: oldzhu <wp_xdzhu@hotmail.com>
MarioHewardt
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to filter on exception message and make a dump file name contains the exception name and dump count.
Resolves #159, Resolves #161