Fixing some leaks in src/Monitor.c code #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 13 is reporting a double free occurence of monitoredProcessMap. It is possible by using `-Werror=analyzer-double-free`. The variable `monitoredProcessMap` is defined as a auto_free which does not require an explicit `free()`. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
If the `clientData` cannot be allocated, it finishes the function earlier, in order to complete the execution properly, the variables need to be ended with `va_end` either. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
MarioHewardt
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset proposes some fixes for:
monitoredProcessMapinMonitorProcesses()due to anauto_freevariable and severalfree()calls.va_endcall whenGetClientDataHelper()finished early.Most of these errors were reported by GCC 13 and they seem reasonable.