Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for model specific prompting to better show citations #184

Merged
merged 10 commits into from
Aug 31, 2023

Conversation

dayland
Copy link
Contributor

@dayland dayland commented Aug 31, 2023

In this PR we have added new logic to:

  • Lookup the AOAI deployment to retrieve the underlying model and version
  • Updated the prompt engineering to be specific to model type as we have found that trying to use one system prompt for both gpt-35-turbo and gpt-4 led to degradation of one or the other.
  • Added new management Service Principal that is used to query the AOAI deployment via Azure Cognitive Services Management python library
  • Added extra values to the "Info" panel in the UX to show the model name and version and other useful information
  • Updated the App Service configuration values to use conditional check to properly populate when not using an existing AOAI instance
  • Changed max token paramater value to 1024 for generated responses when making API call to generate final response to avoid token overflow error.

Fixes #162
Fixes #174

Copy link
Contributor

@ArpitaisAn0maly ArpitaisAn0maly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Approved. Updated comment section to reflect token count change to API call.

@dayland dayland merged commit e8759b9 into vNext-Dev Aug 31, 2023
2 checks passed
@dayland dayland deleted the aparmar/5947-citation-GPT-Model branch August 31, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants