Geeartl/5973 title issue #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where FR sometimes returns a piece of text identified as the title. This will then replace the title in subsequent chunks. The problem is these chunks would no longer have the context of the main document title. The PR addresses this by concatenating all items identified as title on the first page of a document, or the first item in the document identified as a title if it is not on page 1. This value is then stored in the title key-value across all subsequent chunks. Sections are still stored in the section key-value. To not lose any value provided by the subsequent pieces of text identified as a title, rightly or wrongly, these are stored in the subtitle key-value. They will be replaced when/if another title is subsequently identified by FR