Skip to content

Commit

Permalink
Merge pull request #4582 from jenshnielsen/driver/alazar
Browse files Browse the repository at this point in the history
Update Alazar drivers to confrom to naming standard
  • Loading branch information
jenshnielsen authored Sep 10, 2022
2 parents 95c8cd4 + db23d49 commit 78197a7
Show file tree
Hide file tree
Showing 9 changed files with 69 additions and 5 deletions.
1 change: 1 addition & 0 deletions docs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ genapi:
../qcodes/instrument_drivers/american_magnetics\* \
../qcodes/instrument_drivers/agilent \
../qcodes/instrument_drivers/AimTTi \
../qcodes/instrument_drivers/AlazarTech \
../qcodes/instrument_drivers/basel \
../qcodes/instrument_drivers/HP \
../qcodes/instrument_drivers/ithaco \
Expand Down
7 changes: 7 additions & 0 deletions docs/drivers_api/AlazarTech.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.. _Alazar_api :

Alazar Tech Drivers
===================

.. automodule:: qcodes.instrument_drivers.AlazarTech
:autosummary:
1 change: 1 addition & 0 deletions docs/make.bat
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ REM for storing drivers, not the lower-case one).
sphinx-apidoc -o _auto -d 10 ..\qcodes ^
..\qcodes\instrument_drivers\agilent\* ^
..\qcodes\instrument_drivers\AimTTi ^
..\qcodes\instrument_drivers\AlazarTech ^
..\qcodes\instrument_drivers\american_magnetics\* ^
..\qcodes\instrument_drivers\basel ^
..\qcodes\instrument_drivers\HP ^
Expand Down
10 changes: 9 additions & 1 deletion qcodes/instrument_drivers/AlazarTech/ATS9360.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from .utils import TraceParameter


class AlazarTech_ATS9360(AlazarTech_ATS):
class AlazarTechATS9360(AlazarTech_ATS):
"""
This class is the driver for the ATS9360 board
it inherits from the ATS base class
Expand Down Expand Up @@ -373,3 +373,11 @@ def _set_trigger_holdoff(self, value: bool) -> None:
disable_mask = ~np.uint32(1 << 26)
new_value = current_value & disable_mask
self._write_register(58, int(new_value))


class AlazarTech_ATS9360(AlazarTechATS9360):
"""
Alias for backwards compatibility. Will eventually be deprecated and removed
"""

pass
10 changes: 9 additions & 1 deletion qcodes/instrument_drivers/AlazarTech/ATS9373.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from qcodes.instrument_drivers.AlazarTech.utils import TraceParameter


class AlazarTech_ATS9373(AlazarTech_ATS):
class AlazarTechATS9373(AlazarTech_ATS):
"""
This class is the driver for the ATS9373 board.
Expand Down Expand Up @@ -388,3 +388,11 @@ def _set_trigger_holdoff(self, value: bool) -> None:
disable_mask = ~np.uint32(1 << 26)
new_value = current_value & disable_mask
self._write_register(58, int(new_value))


class AlazarTech_ATS9373(AlazarTechATS9373):
"""
Alias for backwards compatibility. Will eventually be deprecated and removed
"""

pass
10 changes: 9 additions & 1 deletion qcodes/instrument_drivers/AlazarTech/ATS9440.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from .utils import TraceParameter


class AlazarTech_ATS9440(AlazarTech_ATS):
class AlazarTechATS9440(AlazarTech_ATS):
"""
This class is the driver for the ATS9440 board
it inherits from the ATS base class
Expand Down Expand Up @@ -300,3 +300,11 @@ def __init__(self, name: str,
set_cmd=None,
initial_value=1000,
vals=validators.Ints(min_value=0))


class AlazarTech_ATS9440(AlazarTechATS9440):
"""
Alias for backwards compatibility. Will eventually be deprecated and removed
"""

pass
10 changes: 9 additions & 1 deletion qcodes/instrument_drivers/AlazarTech/ATS9870.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from .utils import TraceParameter


class AlazarTech_ATS9870(AlazarTech_ATS):
class AlazarTechATS9870(AlazarTech_ATS):
"""
This class is the driver for the ATS9870 board
it inherits from the ATS base class
Expand Down Expand Up @@ -305,3 +305,11 @@ def __init__(self, name: str,
if model != 'ATS9870':
raise Exception(f"The Alazar board kind is not 'ATS9870',"
f" found '{str(model)}' instead.")


class AlazarTech_ATS9870(AlazarTechATS9870):
"""
Alias for backwards compatibility. Will eventually be deprecated and removed
"""

pass
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


# DFT AcquisitionController
class Demodulation_AcquisitionController(AcquisitionController[float]):
class DemodulationAcquisitionController(AcquisitionController[float]):
"""
This class represents an example acquisition controller. End users will
probably want to use something more sophisticated. It will average all
Expand Down Expand Up @@ -158,3 +158,11 @@ def fit(self, buf: np.ndarray) -> Tuple[float, float]:

# see manual page 52!!! (using unsigned data)
return ampl, math.atan2(ImPart, RePart) * 360 / (2 * math.pi)


class Demodulation_AcquisitionController(DemodulationAcquisitionController):
"""
Alias for backwards compatibility. Will eventually be deprecated and removed
"""

pass
15 changes: 15 additions & 0 deletions qcodes/instrument_drivers/AlazarTech/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
from .ATS import AcquisitionController
from .ATS9360 import AlazarTechATS9360
from .ATS9373 import AlazarTechATS9373
from .ATS9440 import AlazarTechATS9440
from .ATS9870 import AlazarTechATS9870
from .ATS_acquisition_controllers import DemodulationAcquisitionController

__all__ = [
"AcquisitionController",
"AlazarTechATS9360",
"AlazarTechATS9373",
"AlazarTechATS9440",
"AlazarTechATS9870",
"DemodulationAcquisitionController",
]

0 comments on commit 78197a7

Please sign in to comment.