Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test suite errors #24

Closed
eendebakpt opened this issue Feb 4, 2016 · 3 comments · Fixed by #38
Closed

test suite errors #24

eendebakpt opened this issue Feb 4, 2016 · 3 comments · Fixed by #38

Comments

@eendebakpt
Copy link
Contributor

On my system the tests (python setup.py nosetests) fail:

Traceback (most recent call last):
  File "/home/eendebakpt/develop/Qcodes/qcodes/tests/test_helpers.py", line 104, in test_yes
    f = open(os.listdir('.')[0], 'r')
IsADirectoryError: [Errno 21] Is a directory: 'qcodes'

I think the code is intended to check whether a file handle is a sequence. On my system the first element of os.listdir('.') is a directory and this generates an error. I suggest removing the file handle altogether.

A second error occurs in the multi processing tests:

======================================================================
FAIL: test_qcodes_process (qcodes.tests.test_multiprocessing.TestQcodesProcess)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.4/unittest/mock.py", line 1136, in patched
    return func(*args, **keywargs)
  File "/home/eendebakpt/develop/Qcodes/qcodes/tests/test_multiprocessing.py", line 82, in test_qcodes_process
    self.assertEqual(len(reprs), 2, reprs)
AssertionError: 3 != 2 : ['<p2, started daemon>', '<p1, started daemon>', '<ForkProcess(SyncManager-1, started)>']

Apparently on my system not only the daemons are started, but also a side process which gets counted accidentally. I think we should either replace the check self.assertEqual(len(reprs), 2, reprs) with something more sophisticated (e.g. check names or id's) or do not do this kind of tests as they are very system dependent.

@alexcjohnson
Copy link
Contributor

@eendebakpt thanks - what platform are you on, Linux I guess? Turns out on Windows, which should really be my primary testing platform, there are even more errors... I'm spending some time beefing up tests today and will try to address all of these - I'll ping you when I have a PR, perhaps you can tell me if I've succeeded?

@alexcjohnson
Copy link
Contributor

@eendebakpt I don't have linux available to test on, but I think this is closed by #47 - can you see if you're happy with the new test runner python qcodes/test.py (and it works correctly) and close this if so?

@eendebakpt
Copy link
Contributor Author

It works now, I am closing the issue.

jenshnielsen referenced this issue in jenshnielsen/Qcodes Apr 5, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Apr 10, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes May 2, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Jun 1, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Jun 22, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Jun 27, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Jul 7, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Jul 18, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 3, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 3, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 7, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 9, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 10, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 16, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 18, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Aug 22, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Sep 21, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
nataliejpg pushed a commit to nataliejpg/Qcodes that referenced this issue Oct 11, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Oct 27, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Nov 21, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
jenshnielsen referenced this issue in jenshnielsen/Qcodes Nov 23, 2017
* make it possible to add a title to device annotator

* Fix: add default title to device annotator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants