-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subprocess widget #13
Conversation
That looks pretty cool! On 26 Jan 2016, at 11:16, alexcjohnson <notifications@github.commailto:notifications@github.com> wrote: @akhmerovhttps://github.com/akhmerov re: #10 (comment)qdev-dk-archive#10 (comment) - output appearing in the notebook server terminal... here I'm collecting it in a console that lives in the corner of the screen, shows what subprocesses are running and allows you to abort measurement loops. @AdriaanRolhttps://github.com/AdriaanRol @guenphttps://github.com/guenp look reasonable? [subprocess widget]https://cloud.githubusercontent.com/assets/2678795/12586402/686b211e-c450-11e5-9d0a-e1d6f91217d1.png You can view, comment on, or merge this pull request online at: Commit Summary
File Changes
Patch Links: — |
No, but that's a great idea! Talking with folks here today about adopting qcodes, it came up that we should also log all the code cells that are run, in case users overwrite a cell or call a cell multiple times. Do you think it makes sense to put these together in one file? |
Way better than the server terminal! Why not regular
I find this tricky, because a notebook may quite easily be used also for non-Qcodes things. Preferably only the Qcodes calls would be logged by Qcodes, and in that case, the cells themselves aren't relevant. Logs with all cells are already relatively hard to parse by a human, since it has to be done by hand, even more so if also mixed with process status warnings. Also a bonus question: while I'm a huge jupyter fan, what happens with these warnings if the user runs a |
Yeah sounds good, if it's readable enough :) Guenevere Prawiroatmodjo On 26 jan. 2016, at 16:26, alexcjohnson <notifications@github.commailto:notifications@github.com> wrote: @guenphttps://github.com/guenp Is this saved in a log file, as well? No, but that's a great idea! Talking with folks here today about adopting qcodes, it came up that we should also log all the code cells that are run, in case users overwrite a cell or call a cell multiple times. Do you think it makes sense to put these together in one file? — |
Isn't it? I subclassed my own subclass of
I played with that a bit but didn't like it as much for the default, but that would be an easy option to add, good point.
Haven't heard and not seeing it in a quick search, can you point me to it?
This console will only show up if you ask for it and we could certainly make logging optional - like if you want the console to watch analysis or monitoring subprocesses (though those subprocesses have to inherit from
Correct. If you're not in a notebook the standard top-level import of this routine won't even exist. In that case, or if you don't show the console, or if it goes away, then it won't be watching the associated queue. And if nobody is watching the queue for more than a few seconds it starts spitting everything to stdout (in addition to the queue) - but maybe you're right that stderr would be better. Though, now that you mention it, the few second delay could be ruinous in some cases - I suppose I could call that same test for whether you're in a notebook before starting the |
@alexcjohnson thanks for the clarification, I agree with everything (also sorry I didn't notice the inheritance from JupyterLab is the codeword for the new plugin-based web UI they are developing (see roadmap. It will allow to design jupyter-powered custom applications (spreadsheet is one example the devs always bring up), and notebook would be one out of many. |
I'm going to add logging in another PR because it has a few more issues to sort out first. |
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
* feat: Add station to init Add a station to init and make a device image if it does not exist. Breaking changes: init now requires a station * fix: Don't save ann. img. in main folder Save annotated device images in the data subfolders.
@akhmerov re: qdev-dk-archive#10 (comment) - output appearing in the notebook server terminal... here I'm collecting it in a console that lives in the corner of the screen, shows what subprocesses are running and allows you to abort measurement loops.
@AdriaanRol @guenp look reasonable?