Keithley2400 driver #235
Keithley2400 driver #235
Conversation
| self.add_parameter('resistance', | ||
| get_cmd=':READ?', | ||
| get_parser=self._resistance_parser, | ||
| label='Voltage', |
There was a problem hiding this comment.
This label is probably not correct?
And the units neither?
|
Issues
======
- Added 8
Complexity increasing per file
==============================
- qcodes/instrument_drivers/tektronix/Keithley_2400.py 3
See the complete overview on Codacy |
| MerlinSmiler = [float(x) for x in msg.split(',')] | ||
| return MerlinSmiler[0] | ||
|
|
||
| def _curr_parser(self, msg): |
There was a problem hiding this comment.
There was a problem hiding this comment.
|
Issues
======
- Added 8
Complexity increasing per file
==============================
- qcodes/instrument_drivers/tektronix/Keithley_2400.py 3
See the complete overview on Codacy |
| def reset(self): | ||
| self.write(':*RST') | ||
|
|
||
| def _volt_parser(self, msg): |
There was a problem hiding this comment.
| label='Voltage', | ||
| units='V') | ||
|
|
||
| self.add_parameter('curr', |
|
|
||
| self.add_parameter('volt', | ||
| get_cmd=':READ?', | ||
| get_parser=self._volt_parser, |
| MerlinSmiler = [float(x) for x in msg.split(',')] | ||
| return MerlinSmiler[0] | ||
|
|
||
| def _curr_parser(self, msg): |
There was a problem hiding this comment.
| MerlinSmilerIkke = [float(x) for x in msg.split(',')] | ||
| return MerlinSmilerIkke[1] | ||
|
|
||
| def _resistance_parser(self, msg): |
There was a problem hiding this comment.
|
|
||
| self.add_parameter('resistance', | ||
| get_cmd=':READ?', | ||
| get_parser=self._resistance_parser, |
| else: | ||
| raise AttributeError('Mode does not exist') | ||
| self.write(':SOUR:FUNC {:s}'.format(msg)) | ||
|
|
|
|
||
| self.add_parameter('curr', | ||
| get_cmd=':READ?', | ||
| get_parser=self._curr_parser, |
|
Issues
======
- Added 8
Complexity increasing per file
==============================
- qcodes/instrument_drivers/tektronix/Keithley_2400.py 3
See the complete overview on Codacy |
This is a clean-up of PR microsoft#235. I suspect buggy behaviour but have not tested the driver.
|
This is now superseded by PR #488 I'm closing this PR and deleting the branch. |
clean-up of PR #235. I suspect buggy behaviour but have not tested the driver.
Changes proposed in this pull request:
@giulioungaretti @alexcjohnson @MerlinSmiles