Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add check whether instrument name is valid identifier #4178

Merged
merged 14 commits into from
Jun 9, 2022
Merged

feature: Add check whether instrument name is valid identifier #4178

merged 14 commits into from
Jun 9, 2022

Commits on May 17, 2022

  1. feature: Add check whether instrument name is valid identifier

    @maximilianluc
    maximilianluc committed May 17, 2022
    Configuration menu
    Copy the full SHA
    60b7c86 View commit details
    Browse the repository at this point in the history

  2. Add test for invalid identifier + fix lint issues

    @maximilianluc
    maximilianluc committed May 17, 2022
    Configuration menu
    Copy the full SHA
    69236fb View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Linting fix. Edit error message instr identifier.

    @maximilianluc
    maximilianluc committed May 19, 2022
    Configuration menu
    Copy the full SHA
    c5a6ef4 View commit details
    Browse the repository at this point in the history

  2. linting fix

    @maximilianluc
    maximilianluc committed May 19, 2022
    Configuration menu
    Copy the full SHA
    e7fe869 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Update docs. Identifier check to InstrumentBase.

    @maximilianluc
    maximilianluc committed May 20, 2022
    Configuration menu
    Copy the full SHA
    41d08a1 View commit details
    Browse the repository at this point in the history

  2. Small elaboration changelog. Fix pre-commit test.

    @maximilianluc
    maximilianluc committed May 20, 2022
    Configuration menu
    Copy the full SHA
    8af4148 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Merge branch 'master' into feature/instrument-identifier-check

    @jenshnielsen
    jenshnielsen authored Jun 3, 2022
    Configuration menu
    Copy the full SHA
    925d937 View commit details
    Browse the repository at this point in the history

  2. Not needed to mention issue in changelog fragment

    @jenshnielsen
    jenshnielsen authored Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b256032 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Merge branch 'QCoDeS:master' into feature/instrument-identifier-check

    @maximilianluc
    maximilianluc authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    6dba5b4 View commit details
    Browse the repository at this point in the history

  2. Warning + fix for instrument names with dashes

    @maximilianluc
    maximilianluc committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    546c80f View commit details
    Browse the repository at this point in the history

  3. Fix - make identifier check staticmethod

    @maximilianluc
    maximilianluc committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d87ad99 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Remove tinker.w 

    tinker.w unused
    @maximilianluc
    maximilianluc authored Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a1ab755 View commit details
    Browse the repository at this point in the history

  2. Reverse order warning and valueerror

    @maximilianluc
    maximilianluc committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    4433d01 View commit details
    Browse the repository at this point in the history

  3. Add warnings test for identifiers in unit tests

    @maximilianluc
    maximilianluc committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    8f569f9 View commit details
    Browse the repository at this point in the history