Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update R and S drivers to conform to docs standard #4595

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Update R and S drivers to conform to docs standard #4595

merged 4 commits into from
Sep 12, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Sep 11, 2022 •
edited
Loading

  • Remove private module and its tests. These are only used in drivers that are moved to contrib_drivers and should have been deleted then.

@jenshnielsen jenshnielsen mentioned this pull request Sep 11, 2022
Closed
@jenshnielsen jenshnielsen added driver docs Related to docs improvements labels Sep 11, 2022
@jenshnielsen jenshnielsen added this to the Public api rewrite milestone Sep 11, 2022
@codecov
Copy link

codecov bot commented Sep 11, 2022 •
edited
Loading

Codecov Report

Merging #4595 (93ef162) into master (9539774) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 93ef162 differs from pull request most recent head 669bd6a. Consider uploading reports for the commit 669bd6a to get more accurate results

@@            Coverage Diff             @@
##           master    #4595      +/-   ##
==========================================
+ Coverage   68.20%   68.22%   +0.01%     
==========================================
  Files         333      333              
  Lines       31671    31671              
==========================================
+ Hits        21602    21607       +5     
+ Misses      10069    10064       -5

@jenshnielsen jenshnielsen marked this pull request as ready for review September 12, 2022 12:03
@jenshnielsen jenshnielsen merged commit 692cbca into microsoft:master Sep 12, 2022
@jenshnielsen jenshnielsen deleted the driver/rands branch September 12, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
docs Related to docs improvements driver
Projects
None yet
Milestone
Public api rewrite
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshnielsen @astafan8