Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace config context managers with pytest fixtures #4764

Merged
merged 7 commits into from
Oct 25, 2022

Conversation

jenshnielsen
Copy link
Collaborator

Extracted from #4763

  • Using fixtures avoids the patterns of tests that are completely within a context manger improving readability
  • Since the context mangers cooperate, we avoid the logic of having to patch config objects within the test

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #4764 (2101279) into master (ad5821c) will decrease coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4764      +/-   ##
==========================================
- Coverage   68.19%   67.27%   -0.93%     
==========================================
  Files         339      339              
  Lines       32003    32003              
==========================================
- Hits        21826    21530     -296     
- Misses      10177    10473     +296     

@jenshnielsen jenshnielsen merged commit fe84e52 into microsoft:master Oct 25, 2022
@jenshnielsen jenshnielsen deleted the reset_config_fixture branch October 25, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants