simplify find_instrument type #5293
Merged
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Jul 31, 2023
Codecov Report
@@ Coverage Diff @@
## master #5293 +/- ##
==========================================
- Coverage 67.50% 67.50% -0.01%
==========================================
Files 359 359
Lines 29885 29884 -1
==========================================
- Hits 20174 20173 -1
Misses 9711 9711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't know the type of the instrument the returned type should simply be Instrument not T. This matches the overload and avoids a cast to an undefined type