Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup logging and str formatting #5340

Merged
merged 9 commits into from
Sep 4, 2023

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Sep 2, 2023

Only use logformatting or f strings to format logs. Ideally we should only use log formatting and not f strings for performance but this is at least a step in the right direction.

Use ruff to enforce this.

Also fix and enforce implicit-str-concat-isc

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #5340 (5e1f5f6) into master (6a0d2dc) will increase coverage by 0.02%.
The diff coverage is 41.41%.

@@            Coverage Diff             @@
##           master    #5340      +/-   ##
==========================================
+ Coverage   67.60%   67.62%   +0.02%     
==========================================
  Files         360      360              
  Lines       30056    30058       +2     
==========================================
+ Hits        20318    20327       +9     
+ Misses       9738     9731       -7     

@jenshnielsen jenshnielsen changed the title Cleanup logging Cleanup logging and str formatting Sep 2, 2023
qcodes/instrument_drivers/tektronix/AWG5014.py Outdated Show resolved Hide resolved
qcodes/parameters/multi_parameter.py Outdated Show resolved Hide resolved
qcodes/utils/helpers.py Show resolved Hide resolved
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup! ruff rocks :)

@jenshnielsen jenshnielsen added this pull request to the merge queue Sep 4, 2023
Merged via the queue into microsoft:master with commit edae760 Sep 4, 2023
13 of 15 checks passed
@jenshnielsen jenshnielsen deleted the ruff_log branch September 4, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants