Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Agilent drivers #6089

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 19, 2024

This is an example of applying #4412 to Agilent drivers

  • Convert attributes to be assigned using automatic tool
  • Move model specific parameters into submodels so they can be declared statically
  • Document baseclass and disable documentation of inherited attributes. This is such that the duplication is reduced and the docs becomes more readable.
  • newsfragment

@jenshnielsen jenshnielsen requested a review from a team as a code owner May 19, 2024 17:17
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 67.62%. Comparing base (8713dbc) to head (6959423).

Files Patch % Lines
...codes/instrument_drivers/agilent/Agilent_E8267C.py 0.00% 18 Missing ⚠️
...odes/instrument_drivers/agilent/_Agilent_344xxA.py 14.28% 12 Missing ⚠️
...codes/instrument_drivers/agilent/Agilent_E8257D.py 11.11% 8 Missing ⚠️
...codes/instrument_drivers/agilent/Agilent_34410A.py 54.54% 5 Missing ⚠️
...codes/instrument_drivers/agilent/Agilent_34411A.py 54.54% 5 Missing ⚠️
...codes/instrument_drivers/agilent/Agilent_34401A.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6089      +/-   ##
==========================================
- Coverage   67.67%   67.62%   -0.05%     
==========================================
  Files         352      352              
  Lines       30704    30740      +36     
==========================================
+ Hits        20780    20789       +9     
- Misses       9924     9951      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 22, 2024
Merged via the queue into microsoft:main with commit 6e27c03 May 22, 2024
18 of 20 checks passed
@jenshnielsen jenshnielsen deleted the refactor_agilent branch May 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants