Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Keithley drivers #6115

Merged
merged 10 commits into from
May 24, 2024
Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 23, 2024

Convert all Keithley drivers to new add_parameter format.
Don't document inherited attributes
Document base classes
A fix docs fixes

TODO

  • News fragment

@jenshnielsen jenshnielsen requested a review from a team as a code owner May 23, 2024 19:34
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 71.94245% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 67.65%. Comparing base (10785d5) to head (00934db).
Report is 9 commits behind head on main.

Files Patch % Lines
...codes/instrument_drivers/Keithley/Keithley_2000.py 0.00% 30 Missing ⚠️
...codes/instrument_drivers/Keithley/Keithley_2400.py 0.00% 24 Missing ⚠️
...codes/instrument_drivers/Keithley/Keithley_6500.py 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6115      +/-   ##
==========================================
+ Coverage   67.63%   67.65%   +0.02%     
==========================================
  Files         352      352              
  Lines       30746    30886     +140     
==========================================
+ Hits        20795    20896     +101     
- Misses       9951     9990      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 24, 2024
Merged via the queue into microsoft:main with commit 6392f13 May 24, 2024
20 checks passed
@jenshnielsen jenshnielsen deleted the keithley_refactor branch May 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants