Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor drivers Minicircuits - R&S #6160

Merged
merged 19 commits into from
Jun 7, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jun 6, 2024

  • News fragment

@jenshnielsen jenshnielsen requested a review from a team as a code owner June 6, 2024 07:20
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 45.76577% with 301 lines in your changes missing coverage. Please review.

Project coverage is 67.37%. Comparing base (b063de6) to head (64579e8).
Report is 6 commits behind head on main.

Files Patch % Lines
src/qcodes/instrument_drivers/rohde_schwarz/ZNB.py 10.34% 52 Missing ⚠️
src/qcodes/instrument_drivers/oxford/triton.py 0.00% 42 Missing ⚠️
...des/instrument_drivers/Minicircuits/USBHIDMixin.py 27.27% 40 Missing ⚠️
...rc/qcodes/instrument_drivers/rigol/Rigol_DG1062.py 0.00% 32 Missing ⚠️
...ent_drivers/QuantumDesign/DynaCoolPPMS/DynaCool.py 0.00% 28 Missing ⚠️
...rc/qcodes/instrument_drivers/rigol/Rigol_DG4000.py 0.00% 26 Missing ⚠️
...c/qcodes/instrument_drivers/rigol/private/DP8xx.py 4.34% 22 Missing ⚠️
...rc/qcodes/instrument_drivers/QDev/QDac_channels.py 0.00% 21 Missing ⚠️
...rc/qcodes/instrument_drivers/rigol/Rigol_DS4000.py 0.00% 18 Missing ⚠️
...drivers/Minicircuits/_minicircuits_rudat_13g_90.py 0.00% 12 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6160      +/-   ##
==========================================
- Coverage   67.59%   67.37%   -0.23%     
==========================================
  Files         352      352              
  Lines       31562    31860     +298     
==========================================
+ Hits        21335    21465     +130     
- Misses      10227    10395     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool! especially the Rhode Schwarz :)

@jenshnielsen jenshnielsen added this pull request to the merge queue Jun 7, 2024
Merged via the queue into microsoft:main with commit e06393b Jun 7, 2024
18 of 20 checks passed
@jenshnielsen jenshnielsen deleted the minicircuits_refactor branch June 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants