Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters related to reference oscillator to R&S ZNB driver #6352

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mgunyho
Copy link
Contributor

@mgunyho mgunyho commented Aug 14, 2024

As the title says. Tested with a real device. Let me know if there is any issue with the formatting etc.

@mgunyho mgunyho requested a review from a team as a code owner August 14, 2024 14:29
@mgunyho
Copy link
Contributor Author

mgunyho commented Aug 14, 2024

@microsoft-github-policy-service agree company="Aalto University"

@mgunyho mgunyho changed the title Add parameters related to reference oscillator to ZNB driver Add parameters related to reference oscillator to R&S ZNB driver Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.29%. Comparing base (c5eedf9) to head (ff7e086).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/instrument_drivers/rohde_schwarz/ZNB.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6352      +/-   ##
==========================================
- Coverage   67.30%   67.29%   -0.02%     
==========================================
  Files         352      352              
  Lines       32146    32156      +10     
==========================================
+ Hits        21637    21638       +1     
- Misses      10509    10518       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgunyho mgunyho force-pushed the ZNB-ref-osc branch 2 times, most recently from 635d6bd to 5fcfd99 Compare August 15, 2024 09:02
@jenshnielsen jenshnielsen added this pull request to the merge queue Sep 5, 2024
Merged via the queue into microsoft:main with commit 0b43223 Sep 5, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants