Skip to content

Commit

Permalink
Remove rarely true check in char_traits::move (#2083)
Browse files Browse the repository at this point in the history
  • Loading branch information
AreaZR authored Aug 6, 2021
1 parent 4721611 commit d3840f4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions stl/inc/xstring
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@ struct _Char_traits { // properties of a string or stream element
// If _First1 is in the src range, we need a backward loop.
// Otherwise, the forward loop works (even if the back of dest overlaps the front of src).

if (_First1 == _First2) {
return _First1; // Self-assignment; either loop would work, but returning immediately is faster.
}

// Usually, we would compare pointers with less-than, even though they could belong to different arrays.
// However, we're not allowed to do that during constant evaluation, so we need a linear scan for equality.
bool _Loop_forward = true;
Expand Down

0 comments on commit d3840f4

Please sign in to comment.