-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STL: Consider consistently rephrasing Standard mode diagnostics #250
Comments
My preference: "The contents of |
Didn't @BillyONeal suggest that we should invert the conditionals that guard these "downlevel" diagnostics so the |
There's code inconsistencies too.
Line 478 in 3b0a1c9
Line 37 in 3b0a1c9
Line 367 in 3b0a1c9
Double sided arrows Line 1753 in 3b0a1c9
|
When a header for a newer C++ Standard is compiled with an older Standard mode, it emits a diagnostic. Our phrasing varies; some talk about the contents of the header:
STL/stl/inc/charconv
Line 3101 in 28ec9a3
Others talk about the main class or class template defined by that header:
STL/stl/inc/any
Line 445 in 28ec9a3
STL/stl/inc/variant
Line 1754 in 28ec9a3
Some don't bother to say "class" (and ignore the distinction between the
basic_string_view
class template and thestring_view
typedef):STL/stl/inc/string_view
Line 15 in 28ec9a3
And some have custom phrasing:
STL/stl/inc/execution
Line 5141 in 28ec9a3
Should we be consistent about this phrasing?
The text was updated successfully, but these errors were encountered: