Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2602R2 Poison Pills Are Too Toxic #3209

Closed
StephanTLavavej opened this issue Nov 14, 2022 · 0 comments · Fixed by #3215
Closed

P2602R2 Poison Pills Are Too Toxic #3209

StephanTLavavej opened this issue Nov 14, 2022 · 0 comments · Fixed by #3215
Labels
cxx23 C++23 feature fixed Something works now, yay!

Comments

@StephanTLavavej
Copy link
Member

P2602R2 Poison Pills Are Too Toxic

Increased feature-test macro:

#define __cpp_lib_ranges 202211L
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Nov 14, 2022
CaseyCarter added a commit to CaseyCarter/STL that referenced this issue Nov 15, 2022
@CaseyCarter
P2606R2 Poison Pills Are Too Toxic
348fc3c 
Consistently annotate throughout with `// intentional ADL` and `// Block unqualified name lookup`.

Drive-by:
* Consistently use east `const` in `P0896R4_ranges_machinery`.
* Feeature-test macro test fixes:
  * `__cpp_lib_concepts` should not be defined in sub-C++20-modes
  * `__cpp_lib_ranges` should not be defined in sub-C++20 modes even if `__cpp_lib_concepts` is defined. (This is redundant with the previous fix, but it doesn't hurt anything.)

Fixes microsoft#3209
CaseyCarter added a commit to CaseyCarter/STL that referenced this issue Nov 15, 2022
@CaseyCarter
P2606R2 Poison Pills Are Too Toxic
421f1e1 
Consistently annotate throughout with `// intentional ADL` and `// Block unqualified name lookup`.

Drive-by:
* Consistently use east `const` in `P0896R4_ranges_machinery`.
* Feeature-test macro test fixes:
  * `__cpp_lib_concepts` should not be defined in sub-C++20-modes
  * `__cpp_lib_ranges` should not be defined in sub-C++20 modes even if `__cpp_lib_concepts` is defined. (This is redundant with the previous fix, but it doesn't hurt anything.)

Fixes microsoft#3209
@CaseyCarter CaseyCarter mentioned this issue Nov 15, 2022
Merged
CaseyCarter added a commit to CaseyCarter/STL that referenced this issue Nov 15, 2022
@CaseyCarter
P2602R2 Poison Pills Are Too Toxic
e8ed216 
Consistently annotate throughout with `// intentional ADL` and `// Block unqualified name lookup`.

Drive-by:
* Consistently use east `const` in `P0896R4_ranges_machinery`.
* Feeature-test macro test fixes:
  * `__cpp_lib_concepts` should not be defined in sub-C++20-modes
  * `__cpp_lib_ranges` should not be defined in sub-C++20 modes even if `__cpp_lib_concepts` is defined. (This is redundant with the previous fix, but it doesn't hurt anything.)

Fixes microsoft#3209
@StephanTLavavej StephanTLavavej mentioned this issue Nov 17, 2022
Open
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Dec 6, 2022
@frederick-vs-ja frederick-vs-ja mentioned this issue Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cxx23 C++23 feature fixed Something works now, yay!
Projects
STL C++23 Features
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

P2602R2 Poison Pills Are Too Toxic CaseyCarter/STL
1 participant
@StephanTLavavej