Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<random>: Fix discrete_distribution result out of range #1025

Merged
merged 10 commits into from
Jul 27, 2020
Merged

<random>: Fix discrete_distribution result out of range #1025

merged 10 commits into from
Jul 27, 2020

Commits on Jul 9, 2020

  1. Fix discrete_distribution result out of range 

    Mathematically, _Par0._Pcdf.back() should be one. However, when it is
actually slightly smaller than one due to rounding error, there is a
small probability that _Px > _Par0._Pcdf.back() and the original code
returns the invalid value of _Par0._Pcdf.size().
    @statementreply
    statementreply committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1bd796a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Update stl/inc/random 

    Use _Prev_iter

Co-authored-by: Casey Carter <cartec69@gmail.com>
    @statementreply @CaseyCarter
    statementreply and CaseyCarter authored Jul 10, 2020
    Configuration menu
    Copy the full SHA
    786e7aa View commit details
    Browse the repository at this point in the history

  2. Add regression test

    @statementreply
    statementreply committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    b71dc47 View commit details
    Browse the repository at this point in the history

  3. tests: Make bad_rng_pattern_generator a forward iterator

    @statementreply
    statementreply committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    9716e01 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2020

  1. Fix comment typo

    @statementreply
    statementreply committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    009dbf1 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2020

  1. Minor fixes

    @statementreply
    statementreply committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    e009f03 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_discrete_distribution_out_of_range

    @statementreply
    statementreply committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    7ad4ee9 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Address review comments

    @statementreply
    statementreply committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7873c70 View commit details
    Browse the repository at this point in the history

  2. Update #include after moving header file

    @statementreply
    statementreply committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7036941 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. Apply suggestions from code review

    @StephanTLavavej
    StephanTLavavej authored Jul 25, 2020
    Configuration menu
    Copy the full SHA
    22bf422 View commit details
    Browse the repository at this point in the history