feature/spaceship: Clause 22: Containers #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
force-pushed
the
feature/spaceship
branch
from
52c7be9
to
8fcc25f
Compare
StephanTLavavej
force-pushed
the
feature/spaceship
branch
from
e56b1ba
to
81aff9b
Compare
StephanTLavavej
changed the title
StephanTLavavej
requested changes
Jul 16, 2020
There was a problem hiding this comment.
Thanks for this first batch of 🛸 work! I've reviewed everything and it looks solid; although some fixes are necessary, I think they should be relatively straightforward. (The biggest unknown is how to test synth-three-way and I would be comfortable marking that as a FIXME if you want.) Then it should be ready to be merged into the feature branch.
This comment has been minimized.
This comment has been minimized.
queue<T, NonSpaceshipContainer> might be instantiated for a non-three_way_comparable NonSpaceshipContainer. In that case, it shouldn't attempt to grant friendship to the spaceship operator, because that would attempt to form compare_three_way_result_t<NonSpaceshipContainer>. As far as I can tell, there's no way in the Core Language for a queue to grant friendship to only one specialization of its non-member spaceship operator while respecting the constraint. (See WG21-N4861 [temp.friend]/9.) Instead, we need to template the friendship declaration, such that queue grants friendship to all of its spaceship operators. This is safe, just verbose.
StephanTLavavej
force-pushed
the
feature/spaceship
branch
from
992b036
to
1dc5c43
Compare
This comment has been minimized.
This comment has been minimized.
CaseyCarter
reviewed
Jul 23, 2020
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Casey Carter <Casey@Carter.net>
This comment has been minimized.
This comment has been minimized.
Testing `_Differing_bits == 0` might seem like it's asking the compiler to do more work (always XORing). But it allows the compiler to see that the input to `_Countr_zero` is nonzero, and that allows it to optimize away the runtime ISA check, unconditionally emitting a `tzcnt` instruction. Then, at the end of the function, we know something that the compiler doesn't realize: `_Mask` selects a differing bit (the least significant one), so `(_Left & _Mask)` and `(_Right & _Mask)` are zero/nonzero or vice versa. Therefore, we only need to inspect one side! I've verified that each of these changes improves the codegen. Co-authored-by: Casey Carter <Casey@Carter.net>
This comment has been minimized.
This comment has been minimized.
CaseyCarter
reviewed
Jul 25, 2020
CaseyCarter
approved these changes
Jul 28, 2020
StephanTLavavej
requested changes
Jul 28, 2020
StephanTLavavej
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Going to merge this into the feature branch after the tests run! 🎉 😸 🛸
I've added a note to the Spaceship Project that we need to implement spaceships for the container iterators too (which are Clause 22); that shouldn't hold up this significant PR.
|
Thanks for implementing the important |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #62 for Clause 22, Containers.