Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ranges::nth_element #1063

Merged
merged 5 commits into from
Aug 1, 2020

Conversation

CaseyCarter
Copy link
Member

No description provided.

@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Jul 20, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 20, 2020 16:59
@CaseyCarter CaseyCarter mentioned this pull request Jul 20, 2020
stl/inc/algorithm Outdated Show resolved Hide resolved
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These simplealgorithms made my brain burn, freeze and melt at the same time. Impressive

stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only trivial changes requested.

stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_nth_element/test.cpp Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Jul 31, 2020
@StephanTLavavej StephanTLavavej merged commit e58a945 into microsoft:master Aug 1, 2020
@StephanTLavavej
Copy link
Member

Thanks for implementing the Nth ranges algorithm! 😺

@CaseyCarter CaseyCarter deleted the nth_element branch August 2, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants