Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::ssize #1076

Merged
merged 5 commits into from
Aug 1, 2020
Merged

Implement ranges::ssize #1076

merged 5 commits into from
Aug 1, 2020

Conversation

CaseyCarter
Copy link
Member

...per the proposed resolution of LWG-3403, which I just wrote and submitted to the LWG issues list (cplusplus/LWG#328).

Partially addresses #39.

@CaseyCarter
Implement ranges::ssize
7223c04 
...per the proposed resolution of LWG-3403, which I just wrote and submitted to the LWG issues list (cplusplus/LWG#328).
@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Jul 22, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 22, 2020 04:40
@CaseyCarter CaseyCarter mentioned this pull request Jul 22, 2020
Closed
StephanTLavavej
StephanTLavavej requested changes Jul 22, 2020
View reviewed changes
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_range_machinery/test.cpp Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej requested changes Jul 23, 2020
View reviewed changes
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Show resolved Hide resolved
@mnatsuhara mnatsuhara self-assigned this Jul 29, 2020
mnatsuhara
mnatsuhara reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@mnatsuhara mnatsuhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just had one question (which to be fair is about an important part of the overall changes 😛)

stl/inc/xutility Show resolved Hide resolved
mnatsuhara
mnatsuhara approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@mnatsuhara mnatsuhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful explanation! :)

@StephanTLavavej
Copy link
Member

Thanks for the thorough review, @mnatsuhara! I'll add this to the MSVC-PR port so we'll have 10 PRs total.

@StephanTLavavej StephanTLavavej self-assigned this Aug 1, 2020
@StephanTLavavej StephanTLavavej merged commit e2912b6 into microsoft:master Aug 1, 2020
@StephanTLavavej
Copy link
Member

Thanks! This is a sign that the size of the Ranges library is getting close to the max!

@CaseyCarter CaseyCarter deleted the ssize branch August 2, 2020 01:45
@SuperWig
Copy link
Contributor

SuperWig commented Aug 2, 2020

requests eye rolling as a reaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@statementreply statementreply statementreply left review comments

@SuperWig SuperWig SuperWig left review comments

@mnatsuhara mnatsuhara mnatsuhara approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CaseyCarter @StephanTLavavej @SuperWig @statementreply @mnatsuhara