Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::merge #1101

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Implement ranges::merge #1101

merged 3 commits into from
Aug 5, 2020

Conversation

CaseyCarter
Copy link
Member

Partially addresses #39.

@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Jul 28, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 28, 2020 22:48
@CaseyCarter CaseyCarter mentioned this pull request Jul 28, 2020
Closed
@miscco
Copy link
Contributor

miscco commented Jul 29, 2020

Looks great! merge it

StephanTLavavej
StephanTLavavej approved these changes Jul 29, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
@mnatsuhara mnatsuhara self-assigned this Jul 29, 2020
mnatsuhara
mnatsuhara approved these changes Aug 4, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_merge/test.cpp Show resolved Hide resolved
mnatsuhara
mnatsuhara approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@mnatsuhara mnatsuhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That counting_compare is beautiful 😻

@StephanTLavavej StephanTLavavej merged commit 5d00b60 into microsoft:master Aug 5, 2020
@StephanTLavavej
Copy link
Member

ranges::merge merged. 🚨 Warning! 🚨 Pun potential exceeds design capacity.

@CaseyCarter CaseyCarter deleted the merge branch August 5, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaseyCarter @miscco @StephanTLavavej @mnatsuhara