Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait/notify atomic<shared_ptr<T>> (#52, P1644R0) #1136

Merged
merged 11 commits into from
Aug 9, 2020
Merged

wait/notify atomic<shared_ptr<T>> (#52, P1644R0) #1136

merged 11 commits into from
Aug 9, 2020

Conversation

AlexGuteniev
Copy link
Contributor

Another piece of #52

@StephanTLavavej StephanTLavavej changed the title wait/notify atomic<shared_ptr<T> (#52, P1644R0) wait/notify atomic<shared_ptr<T>> (#52, P1644R0) Aug 3, 2020
@StephanTLavavej StephanTLavavej added the cxx20 C++20 feature label Aug 3, 2020
@BillyONeal
Copy link
Member

This strategy looks good to me 👍

@AlexGuteniev AlexGuteniev marked this pull request as ready for review August 4, 2020 18:06
@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 4, 2020 18:06
@AlexGuteniev
Copy link
Contributor Author

I think this is ready for review

StephanTLavavej
StephanTLavavej reviewed Aug 5, 2020
View reviewed changes
stl/inc/memory Show resolved Hide resolved
stl/inc/memory Show resolved Hide resolved
stl/inc/memory Outdated Show resolved Hide resolved
stl/inc/memory Outdated Show resolved Hide resolved
stl/inc/memory Outdated Show resolved Hide resolved
stl/inc/memory Outdated Show resolved Hide resolved
tests/std/include/test_atomic_wait.hpp Outdated Show resolved Hide resolved
@AlexGuteniev @StephanTLavavej
Update tests/std/include/test_atomic_wait.hpp
707046d 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
BillyONeal
BillyONeal approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM modulo Stephan's nitpicks. Thanks!

AdamBucior
AdamBucior reviewed Aug 5, 2020
View reviewed changes
stl/inc/memory Outdated Show resolved Hide resolved
AlexGuteniev and others added 3 commits August 5, 2020 19:08
@AlexGuteniev @AdamBucior
Update stl/inc/memory
03bae8f 
Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>
@AlexGuteniev
this
d35fe92
@AlexGuteniev
Merge branch 'atomic_shared_ptr_wait'
20d0c63
StephanTLavavej
StephanTLavavej approved these changes Aug 6, 2020
View reviewed changes
stl/inc/memory Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Aug 6, 2020
@StephanTLavavej StephanTLavavej self-assigned this Aug 8, 2020
@StephanTLavavej StephanTLavavej merged commit bdf7710 into microsoft:master Aug 9, 2020
@StephanTLavavej
Copy link
Member

Thanks for implementing this feature! I can't wait to notify our users that another part of the C++20 Synchronization Library will be available! 😸

@AlexGuteniev AlexGuteniev deleted the atomic_shared_ptr_wait branch August 10, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBucior AdamBucior AdamBucior left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx20 C++20 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexGuteniev @BillyONeal @StephanTLavavej @AdamBucior