Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache hardware thread count for <execution> #1143

Merged

Conversation

AlexGuteniev
Copy link
Contributor

resolves #1134 (conservatively)
revert to what there were before atomic wait

resolves microsoft#1134 (conservatively)
revert to what there were before atomic wait
@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 4, 2020 06:23
@StephanTLavavej StephanTLavavej added the performance Must go faster label Aug 4, 2020
stl/src/parallel_algorithms.cpp Outdated Show resolved Hide resolved
Co-authored-by: Casey Carter <cartec69@gmail.com>
@BillyONeal
Copy link
Member

It looks like we can remove #include <thread> from <execution> now.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nitpicks about including more headers than we need and about lots of conversions

@BillyONeal BillyONeal changed the title cache HW thread count in <execution> Cache hardware thread count for <execution> Aug 5, 2020
@StephanTLavavej StephanTLavavej merged commit 392fb6d into microsoft:master Aug 9, 2020
@StephanTLavavej
Copy link
Member

Thanks for restoring this performance optimization! 🚀

@AlexGuteniev AlexGuteniev deleted the cache_execution_hw_concurrency branch August 10, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<execution>: cache thread::hardware_concurrency
4 participants