Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _MSVC_STL_UPDATE to August 2020 #1144

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Update _MSVC_STL_UPDATE to August 2020 #1144

merged 1 commit into from
Aug 5, 2020

Conversation

leejy12
Copy link
Contributor

@leejy12 leejy12 commented Aug 4, 2020

Thanks for opening this issue for newcomers!
Closes #1128

@leejy12 leejy12 requested a review from a team as a code owner August 4, 2020 09:54
miscco
miscco approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing to the STL :hooray:

StephanTLavavej
StephanTLavavej approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome, and thanks for the PR! 😸

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Aug 4, 2020
@StephanTLavavej
Copy link
Member

FYI, we'll merge this soon-ish - currently, we need to merge changes simultaneously on GitHub and our MSVC-internal repo, so we like to batch up multiple GitHub PRs into one MSVC-PR. I'd like to gather a few more as we have several in Final Review status.

@StephanTLavavej StephanTLavavej self-assigned this Aug 5, 2020
@StephanTLavavej StephanTLavavej merged commit cbfc527 into microsoft:master Aug 5, 2020
@StephanTLavavej
Copy link
Member

Congratulations on your first microsoft/STL commit! This will ship in VS 2019 16.8 Preview 3, and it is very likely that this will be the final value used in the 16.8 production release. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@miscco miscco miscco approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to August 2020
4 participants
@leejy12 @StephanTLavavej @CaseyCarter @miscco